Skip to content

python/comprehension-merges-dicts

Rule comprehension-merges-dicts
Pack Python
Severity warning
Fix none, edit by hand
Library versions every version

A comprehension that merges dicts with ** for every item builds a new dict for each item and is hard to read. Write a loop that builds each item and fills it with update().

def table(models, catalog):
return [{"id": m.id, **owner(m), **limits(catalog, m)} for m in models]
rows = []
for m in models:
row = {"id": m.id}
row.update(owner(m))
row.update(limits(catalog, m))
rows.append(row)
return rows

The rule reports a comprehension or generator expression that merges dicts with ** for every item.

xpd has no automatic fix, so make the change by hand.

The comprehension builds a whole row in one expression, and every part of the row has to be a helper that returns a dict. A reader follows the loop from top to bottom, and a step in it can grow without the row being rewritten. A comprehension that maps or filters one value per item is still fine.

{**d for d in dicts}, which Python 3.15 added, is not reported.

xpd prints this message with the issue. A name that starts with $ stands for code from your file.

This comprehension merges dicts with ** for every item. Write a loop that builds each item and fills it with update().

Browse the other rules of the Python pack.