Skip to content

pandas/replace-with-mapping

Rule replace-with-mapping
Pack pandas
Severity warning
Fix unsafe, with xpd check --fix --unsafe-fixes
Library versions every version

replace with a mapping takes longer for every key in the mapping. Use map(lambda v: mapping.get(v, v)), which keeps the other values and the dtype.

names = df["name"].replace(mapping)
names = df["name"].map(lambda value: mapping.get(value, value))

The rule reports df["k"].replace(mapping) with a mapping held in a name, and asks for map with mapping.get(v, v). The map form keeps the values that the mapping lacks, and it keeps the dtype.

The file must show that the name holds a dict: the function or the module assigns it a dict, a dict comprehension or a call of dict, or annotates it as dict or Mapping. Any other name is left alone, because a Path and a str have a replace too, as in source.replace(destination).

xpd check --fix --unsafe-fixes applies the fixes of this rule. Check the result, because an unsafe fix can change what the code does.

The unsafe fix writes s.map(lambda v: mapping.get(v, v)). A key of NaN, text mapped to numbers, and a dict of dicts on a frame give another result.

The replacement assumes a plain dict of single values. replace can be faster with a short mapping, and map doesn't replace by regular expression.

xpd prints this message with the issue. A name that starts with $ stands for code from your file.

replace takes longer with every key in the mapping. Write $S.map(lambda v: $M.get(v, v)), which keeps the values and the dtype.

Browse the other rules of the pandas pack.