Skip to content

pandas/reassign-ladder

Rule reassign-ladder
Pack pandas
Severity info, and warning with style = "strict". A rule of the house style
Fix none, edit by hand
Library versions every version

Assigning a frame three or more times in a row from its own methods leaves a half-built frame under the final name after each line. Write the steps as one method chain.

df = df.dropna(subset=["price"])
df = df.rename(columns={"qty": "units"})
df = df.assign(total=pd.col("price") * pd.col("units"))
df = (
df.dropna(subset=["price"])
.rename(columns={"qty": "units"})
.assign(total=pd.col("price") * pd.col("units"))
)

The rule reports the first of three or more statements in a row that each assign one name from a method of itself, as in df = df.dropna(). The rule counts only methods that return a frame or a Series, such as assign, rename, dropna, merge and sort_values, so it leaves a run of str methods alone. Another statement between two of the lines ends the run, and so does a cell marker (# %%, # <codecell> or # In[1]:), so one step in each cell of a file that runs cell by cell is no run. The chain gave a frame equal to the three statements.

xpd has no automatic fix, so make the change by hand.

xpd prints this message with the issue. A name that starts with $ stands for code from your file.

$DF is assigned three or more times in a row, each time from a method of itself, so every line leaves a half-built frame under the final name. Write one chain, as in $DF = $DF.$M1(...).$M2(...).$M3(...), in parentheses with one method per line.

Browse the other rules of the pandas pack.